Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the slic dump command to create dump.sql #183

Merged
merged 12 commits into from
Apr 10, 2024
Merged

Conversation

defunctl
Copy link
Contributor

@defunctl defunctl commented Apr 8, 2024

Adds the slic dump command based on my shell script which performs the same functionality, essentially creating a raw dump.sql for acceptance tests.

I'm not tied to any specific command names or descriptions, so let me know if you need changes.

Help Screen:

image

@defunctl defunctl requested a review from lucatume April 8, 2024 21:03
@defunctl defunctl self-assigned this Apr 8, 2024
Copy link
Contributor

@lucatume lucatume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most likely use case is one of a plugin developer "getting" a new version of WordPress together with slic and having to update the file dumps.
For that reason I would make the WordPress version update optional, and the file required.

I think the command should be called dump-update or something along the line of suggesting that there is an update of the dump involved.

Furthermore, to stick with slic style of input, I would remove the -- options and decide upon the order of arguments.
E.g. slic dump-update <file> [<wp_version>]

slic dump-update tests/_data/dump.sql
slic dump-update tests/_data/dump.sql 6.4.3

Lastly, I understand and appreciate the --yes package-managerism, but the operation is easily reversible with a git checkout (dumps are under version control) and I would just run the update, without confirmation.

@defunctl defunctl requested a review from lucatume April 9, 2024 16:35
@lucatume lucatume changed the base branch from main to 1.6.0 April 10, 2024 08:38
@lucatume lucatume merged commit 5de3de4 into 1.6.0 Apr 10, 2024
@lucatume lucatume deleted the feature/dump-command branch April 10, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants